Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP: fix chaddr parsing #4666

Merged
merged 1 commit into from
Feb 16, 2025
Merged

DHCP: fix chaddr parsing #4666

merged 1 commit into from
Feb 16, 2025

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Feb 16, 2025

  • chaddr should be able to take a MAC address as input and properly pad it
  • chaddr should be able to handle RandMAC() or similar VolatileValues

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.54%. Comparing base (1b690bf) to head (94e325a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/dhcp.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4666   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files         359      359           
  Lines       86559    86565    +6     
=======================================
+ Hits        70583    70592    +9     
+ Misses      15976    15973    -3     
Files with missing lines Coverage Δ
scapy/fields.py 92.86% <100.00%> (ø)
scapy/layers/dhcp.py 82.85% <50.00%> (-0.64%) ⬇️

... and 4 files with indirect coverage changes

@gpotter2 gpotter2 merged commit 1dcad5d into secdev:master Feb 16, 2025
24 checks passed
@gpotter2 gpotter2 deleted the dhcp-chaddr branch February 16, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant