Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BSD loading on 32bits #4669

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Fix BSD loading on 32bits #4669

merged 1 commit into from
Feb 22, 2025

Conversation

gpotter2
Copy link
Member

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (ef6da4b) to head (2f580fa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4669      +/-   ##
==========================================
- Coverage   82.11%   81.33%   -0.79%     
==========================================
  Files         359      359              
  Lines       86576    86576              
==========================================
- Hits        71096    70415     -681     
- Misses      15480    16161     +681     
Files with missing lines Coverage Δ
scapy/arch/bpf/pfroute.py 78.31% <100.00%> (-14.16%) ⬇️

... and 30 files with indirect coverage changes

@sthen
Copy link

sthen commented Feb 22, 2025

Many thanks, confirmed this fixes 32-bit and does not break 64-bit.

@gpotter2
Copy link
Member Author

You're welcome @sthen. Btw I tested sending on the loopback after seeing openbsd/src@473ed62, it seems to work just fine on 2.6.1 (but could indeed have been broken on 2.4.5).

@gpotter2 gpotter2 merged commit 53b9cce into secdev:master Feb 22, 2025
23 of 24 checks passed
@gpotter2 gpotter2 deleted the bds-32bits branch February 22, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenBSD 32-bit, ifaces not populated
2 participants