Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile_filter on *BSD with non-ether linktypes #4670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gpotter2
Copy link
Member

I really have no idea why this line exists in the first place. It makes very little sense to me

@gpotter2
Copy link
Member Author

Ah I see, to allow to compile filters without root. I mean if the filters it compiles are broken it's not that useful.

Shouldn't be hard to fix if the interface type is provided from PFROUTE.

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (ef6da4b) to head (b194a7a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4670      +/-   ##
==========================================
- Coverage   82.11%   81.55%   -0.57%     
==========================================
  Files         359      359              
  Lines       86576    86574       -2     
==========================================
- Hits        71096    70602     -494     
- Misses      15480    15972     +492     
Files with missing lines Coverage Δ
scapy/arch/common.py 68.96% <100.00%> (-1.04%) ⬇️

... and 24 files with indirect coverage changes

@sthen
Copy link

sthen commented Feb 22, 2025

Great, confirmed this fixes things for me. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sr with filter not working on loopback on OpenBSD
2 participants