Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DceRpc fix register_dcerpc_interface duplication #4672

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

gpotter2
Copy link
Member

  • there was leftover code from when I thought versions didn't matter

@gpotter2 gpotter2 merged commit 1bdc210 into secdev:master Feb 23, 2025
23 checks passed
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.11%. Comparing base (53b9cce) to head (538a4e6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/dcerpc.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4672   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         359      359           
  Lines       86576    86573    -3     
=======================================
+ Hits        71088    71093    +5     
+ Misses      15488    15480    -8     
Files with missing lines Coverage Δ
scapy/layers/dcerpc.py 91.42% <75.00%> (+0.24%) ⬆️

... and 10 files with indirect coverage changes

@gpotter2 gpotter2 deleted the dcerpc-dup branch February 23, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant