Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend plan initialize to optionally load OpenFL trained model protobuf file #1290

Merged

Conversation

ishaileshpant
Copy link
Collaborator

@ishaileshpant ishaileshpant commented Jan 21, 2025

  • extend plan initialize to have additional optional argument to take init model path (pbuf format)
  • added new function to utils.py
  • rebased 21.Jan.1
  • reduce cyclo-complexity of initialize function
    Signed-off-by: Shailesh Pant [email protected]

@ishaileshpant ishaileshpant force-pushed the plan_init_load_existing branch 6 times, most recently from 33f77fd to 1470b3b Compare January 21, 2025 07:48
@ishaileshpant ishaileshpant changed the title [WIP] Extend plan initialize to have additional optional argument to take init model path (pbuf format) [WIP] Extend plan initialize optionally load OpenFL trained model protobuf file Jan 21, 2025
@ishaileshpant ishaileshpant force-pushed the plan_init_load_existing branch from 1470b3b to b29be96 Compare January 21, 2025 07:55
@ishaileshpant ishaileshpant marked this pull request as ready for review January 21, 2025 07:55
openfl/interface/plan.py Dismissed Show dismissed Hide dismissed
openfl/interface/plan.py Dismissed Show dismissed Hide dismissed
@ishaileshpant ishaileshpant changed the title [WIP] Extend plan initialize optionally load OpenFL trained model protobuf file Extend plan initialize optionally load OpenFL trained model protobuf file Jan 21, 2025
@ishaileshpant ishaileshpant changed the title Extend plan initialize optionally load OpenFL trained model protobuf file Extend plan initialize to optionally load OpenFL trained model protobuf file Jan 21, 2025
@ishaileshpant ishaileshpant force-pushed the plan_init_load_existing branch from b29be96 to eaf4cb5 Compare January 21, 2025 08:03
openfl/federated/plan/plan.py Show resolved Hide resolved
openfl/interface/plan.py Outdated Show resolved Hide resolved
torch_cnn_mnist_init.pbuf Outdated Show resolved Hide resolved
@ishaileshpant ishaileshpant force-pushed the plan_init_load_existing branch 4 times, most recently from cff6153 to 8894a59 Compare January 21, 2025 10:03
Copy link
Collaborator

@kta-intel kta-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ishaileshpant !

openfl/protocols/utils.py Outdated Show resolved Hide resolved
… init model path (pbuf format)

- added new function to utils.py
- rebased 21.Jan.1
- reduce cyclo-complexity of initialize function
- address review comments
- removed unused imports/vars
Signed-off-by: Shailesh Pant <[email protected]>
@ishaileshpant ishaileshpant force-pushed the plan_init_load_existing branch from 8894a59 to 5c8ddf6 Compare January 23, 2025 05:21
@teoparvanov teoparvanov merged commit 7f0454d into securefederatedai:develop Jan 24, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants