-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend plan initialize to optionally load OpenFL trained model protobuf file #1290
Merged
teoparvanov
merged 1 commit into
securefederatedai:develop
from
ishaileshpant:plan_init_load_existing
Jan 24, 2025
Merged
Extend plan initialize to optionally load OpenFL trained model protobuf file #1290
teoparvanov
merged 1 commit into
securefederatedai:develop
from
ishaileshpant:plan_init_load_existing
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaileshpant
force-pushed
the
plan_init_load_existing
branch
6 times, most recently
from
January 21, 2025 07:48
33f77fd
to
1470b3b
Compare
ishaileshpant
changed the title
[WIP] Extend plan initialize to have additional optional argument to take init model path (pbuf format)
[WIP] Extend plan initialize optionally load OpenFL trained model protobuf file
Jan 21, 2025
ishaileshpant
force-pushed
the
plan_init_load_existing
branch
from
January 21, 2025 07:55
1470b3b
to
b29be96
Compare
ishaileshpant
changed the title
[WIP] Extend plan initialize optionally load OpenFL trained model protobuf file
Extend plan initialize optionally load OpenFL trained model protobuf file
Jan 21, 2025
ishaileshpant
changed the title
Extend plan initialize optionally load OpenFL trained model protobuf file
Extend plan initialize to optionally load OpenFL trained model protobuf file
Jan 21, 2025
ishaileshpant
force-pushed
the
plan_init_load_existing
branch
from
January 21, 2025 08:03
b29be96
to
eaf4cb5
Compare
rahulga1
reviewed
Jan 21, 2025
ishaileshpant
force-pushed
the
plan_init_load_existing
branch
4 times, most recently
from
January 21, 2025 10:03
cff6153
to
8894a59
Compare
kta-intel
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ishaileshpant !
… init model path (pbuf format) - added new function to utils.py - rebased 21.Jan.1 - reduce cyclo-complexity of initialize function - address review comments - removed unused imports/vars Signed-off-by: Shailesh Pant <[email protected]>
ishaileshpant
force-pushed
the
plan_init_load_existing
branch
from
January 23, 2025 05:21
8894a59
to
5c8ddf6
Compare
rahulga1
approved these changes
Jan 23, 2025
teoparvanov
approved these changes
Jan 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shailesh Pant [email protected]