Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated requirements file and readme of Privacy Meter workflow #1295

Conversation

bandatarunkumar
Copy link
Contributor

@bandatarunkumar bandatarunkumar commented Jan 22, 2025

In this PR I've focused on fixing the requirements.txt for Privacy Meter and readme for running the privacy meter workflow, ran the privacy meter workflow with two optimizers(SGD and Adam) for 2 and 10 rounds. The workflow is running as expected without errors. The max CPU consumed while running was 18.8 gb(out of which 3.6 was previously consumed by vscode and other processes), so added note in readme to have atleast 18GB dedicated ram for running the privacy meter experiment.

@bandatarunkumar bandatarunkumar force-pushed the privacy_meter_dependancies_update branch 2 times, most recently from 6408831 to 565d20b Compare January 23, 2025 07:20
Copy link
Collaborator

@teoparvanov teoparvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one suggestion for simplification:

@bandatarunkumar bandatarunkumar force-pushed the privacy_meter_dependancies_update branch from 565d20b to bc025fb Compare January 28, 2025 16:03
@teoparvanov teoparvanov merged commit d9642e8 into securefederatedai:develop Jan 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants