Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskRunner E2E: Parameterised input and coverity fix #1299

Merged
merged 39 commits into from
Jan 23, 2025
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
048c309
Testing GITHUB_STEP_SUMMARY
noopurintel Jan 22, 2025
439c979
Modified
noopurintel Jan 22, 2025
3e05732
Modified
noopurintel Jan 22, 2025
d538750
Initial job added
noopurintel Jan 22, 2025
da804db
Initial job added
noopurintel Jan 22, 2025
ffa5e02
Initial job added
noopurintel Jan 22, 2025
11bfa61
Check GITHUB_STEP_SUMMARY values
noopurintel Jan 22, 2025
61a3889
More changes
noopurintel Jan 22, 2025
b204489
More changes
noopurintel Jan 22, 2025
ee2fcc4
More changes
noopurintel Jan 22, 2025
b84ebd8
More changes
noopurintel Jan 22, 2025
1bc9799
More changes
noopurintel Jan 22, 2025
1d58df5
Summary file check
noopurintel Jan 22, 2025
bc0581e
Correction
noopurintel Jan 22, 2025
731154e
Correction
noopurintel Jan 22, 2025
2e569a7
Correction
noopurintel Jan 22, 2025
93e454f
Correction
noopurintel Jan 22, 2025
ddb5e60
Correction
noopurintel Jan 22, 2025
f121898
Correction
noopurintel Jan 22, 2025
32b7608
Correction
noopurintel Jan 22, 2025
f7ec4bb
Correction
noopurintel Jan 22, 2025
1e15d30
Correction
noopurintel Jan 22, 2025
92b1417
Correction
noopurintel Jan 22, 2025
69ad9b8
Correction
noopurintel Jan 22, 2025
d421595
Correction
noopurintel Jan 22, 2025
23c919c
Correction
noopurintel Jan 22, 2025
c67da55
Correction
noopurintel Jan 22, 2025
76745bb
Correction
noopurintel Jan 22, 2025
b230c94
Correction
noopurintel Jan 22, 2025
3249a86
Correction
noopurintel Jan 22, 2025
94da0df
Correction
noopurintel Jan 22, 2025
04ac6c7
Final changes in E2E yaml
noopurintel Jan 23, 2025
5740e83
Final changes in E2E yaml
noopurintel Jan 23, 2025
e803bf7
Final changes in E2E yaml
noopurintel Jan 23, 2025
ea58cd4
All single quotes
noopurintel Jan 23, 2025
2193391
Double quotes during output assignments
noopurintel Jan 23, 2025
a9b94d4
Modified
noopurintel Jan 23, 2025
36810f8
Modified
noopurintel Jan 23, 2025
a435d40
Check if summary file is valid
noopurintel Jan 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correction
Signed-off-by: noopur <[email protected]>
noopurintel committed Jan 22, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 93e454f9fd4611d01c0b7ff82d2e10c0c11b86cb
34 changes: 21 additions & 13 deletions .github/workflows/task_runner_basic_e2e.yml
Original file line number Diff line number Diff line change
@@ -65,7 +65,7 @@ jobs:
if: |
(github.event_name == 'schedule' && github.repository_owner == 'securefederatedai') ||
(github.event_name == 'workflow_dispatch')
name: Select input values
name: Input value selection
runs-on: ubuntu-22.04
outputs:
selected_jobs: ${{ steps.input_value_selection.outputs.jobs_to_run }}
@@ -89,7 +89,9 @@ jobs:
# Non-TLS - models [torch_cnn_mnist] and python version [3.10]
# No client auth - models [keras_cnn_mnist] and python version [3.10]
# Memory logs - models [torch_cnn_mnist] and python version [3.10]
# ---------------------------------------------------------------
# ---------------------------------------------------------------
echo "jobs_to_run=${{ env.JOBS_TO_RUN }}" >> "$GITHUB_OUTPUT"

if [ "${{ env.MODEL_NAME }}" == 'all' ]; then
echo "models_for_tls=[\"torch_cnn_mnist\", \"keras_cnn_mnist\"]" >> "$GITHUB_OUTPUT"
echo "models_for_non_tls=[\"torch_cnn_mnist\"]" >> "$GITHUB_OUTPUT"
@@ -112,23 +114,29 @@ jobs:
echo "python_for_no_client_auth=[\"${{env.PYTHON_VERSION}}\"]" >> "$GITHUB_OUTPUT"
echo "python_for_memory_logs=[\"${{env.PYTHON_VERSION}}\"]" >> "$GITHUB_OUTPUT"
fi
echo "jobs_to_run=${{ env.JOBS_TO_RUN }}" >> "$GITHUB_OUTPUT"

- name: Print output values
id: print_output_values
run: |
# ---------------------------------------------------------------
# Print the selected values as a summary for better visibility
# ---------------------------------------------------------------
echo "${{ toJSON(steps.input_value_selection.outputs) }}" >> $GITHUB_STEP_SUMMARY
# echo "Selected jobs: $jobs_to_run" >> $GITHUB_STEP_SUMMARY
# echo "Selected models for TLS: $models_for_tls" >> $GITHUB_STEP_SUMMARY
# echo "Selected python versions for TLS: $python_for_tls" >> $GITHUB_STEP_SUMMARY
# echo "Selected models for non-TLS: $models_for_non_tls" >> $GITHUB_STEP_SUMMARY
# echo "Selected python versions for non-TLS: $python_for_non_tls" >> $GITHUB_STEP_SUMMARY
# echo "Selected models for no client auth: $models_for_no_client_auth" >> $GITHUB_STEP_SUMMARY
# echo "Selected python versions for no client auth: $python_for_no_client_auth" >> $GITHUB_STEP_SUMMARY
# echo "Selected models for memory logs: $models_for_memory_logs" >> $GITHUB_STEP_SUMMARY
# echo "Selected python versions for memory logs: $python_for_memory_logs" >> $GITHUB_STEP_SUMMARY
echo "Selected jobs: ${{ steps.input_value_selection.outputs.jobs_to_run }}" >> $GITHUB_STEP_SUMMARY
echo "| Job | Model | Python Version |" >> $GITHUB_STEP_SUMMARY
echo "| ---- | ---- | ---- |" >> $GITHUB_STEP_SUMMARY
if [ "${{ env.JOBS_TO_RUN }}" == 'all' || "${{ env.JOBS_TO_RUN }}" == "test_with_tls" ]; then
echo "| Test with TLS | ${{ steps.input_value_selection.outputs.models_for_tls }} | ${{ steps.input_value_selection.outputs.python_for_tls }} |" >> $GITHUB_STEP_SUMMARY
fi
if [ "${{ env.JOBS_TO_RUN }}" == 'all' || "${{ env.JOBS_TO_RUN }}" == "test_with_non_tls" ]; then
echo "| Test without TLS | ${{ steps.input_value_selection.outputs.models_for_non_tls }} | ${{ steps.input_value_selection.outputs.python_for_non_tls }} |" >> $GITHUB_STEP_SUMMARY
fi
if [ "${{ env.JOBS_TO_RUN }}" == 'all' || "${{ env.JOBS_TO_RUN }}" == "test_with_no_client_auth" ]; then
echo "| Test without client auth | ${{ steps.input_value_selection.outputs.models_for_no_client_auth }} | ${{ steps.input_value_selection.outputs.python_for_no_client_auth }} |" >> $GITHUB_STEP_SUMMARY
fi
if [ "${{ env.JOBS_TO_RUN }}" == 'all' || "${{ env.JOBS_TO_RUN }}" == "test_memory_logs" ]; then
echo "| Test memory logs | ${{ steps.input_value_selection.outputs.models_for_memory_logs }} | ${{ steps.input_value_selection.outputs.python_for_memory_logs }} |" >> $GITHUB_STEP_SUMMARY
fi
echo "" >> $GITHUB_STEP_SUMMARY

test_with_tls:
name: Test with TLS