Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Interactive API #1302

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

MasterSkepticista
Copy link
Collaborator

@MasterSkepticista MasterSkepticista commented Jan 23, 2025

What is this PR about? < PR title >
What changes have been made? < commit messages >
Tests done < CI status below >

Signed-off-by: MasterSkepticista <[email protected]>
Signed-off-by: MasterSkepticista <[email protected]>
Signed-off-by: MasterSkepticista <[email protected]>
@rahulga1
Copy link
Collaborator

we should also remove /openfl/openfl/interface/interactive_api folder and any references to it.

@rahulga1
Copy link
Collaborator

we should also remove /openfl/openfl/interface/interactive_api folder and any references to it.

Also I see some of the places in few files where there is a comment it is used only in native api/interactive api. If that is the case, we should clean this dead code also.

@MasterSkepticista
Copy link
Collaborator Author

Yes, this will be addressed in future commits. PR is currently in draft (marked ready for CI checks).

@payalcha
Copy link
Contributor

payalcha commented Jan 28, 2025

@MasterSkepticista Apart from this openfl/plugins/frameworks_adapters/framework_adapter_interface.py all other plugins are currently used for director and envoy.
That also need to be deprecated right

Also grpc director_server.py and director_client.py is used only in envoy and director.

@MasterSkepticista
Copy link
Collaborator Author

@MasterSkepticista Apart from this openfl/plugins/frameworks_adapters/framework_adapter_interface.py all other plugins are currently used for director and envoy. That also need to be deprecated right

Also grpc director_server.py and director_client.py is used only in envoy and director.

Yes, will remove in subsequent commits

@rahulga1
Copy link
Collaborator

There are still references in following files, Please check if this needs to be taken care
image

@MasterSkepticista MasterSkepticista force-pushed the karansh1/remove_interactive_api branch from cd63ff5 to 8efcc8a Compare January 29, 2025 10:13
Signed-off-by: Shah, Karan <[email protected]>
@MasterSkepticista MasterSkepticista force-pushed the karansh1/remove_interactive_api branch from 8efcc8a to d208600 Compare January 29, 2025 10:15
@MasterSkepticista
Copy link
Collaborator Author

@rahulga1 Resolved until d208600

Could you please check if there are other stale references?

Copy link
Collaborator

@teoparvanov teoparvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, with a couple of comments/suggestions to consider:

Copy link
Collaborator

@rahulga1 rahulga1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants