-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Interactive API #1302
base: develop
Are you sure you want to change the base?
Remove Interactive API #1302
Conversation
Signed-off-by: MasterSkepticista <[email protected]>
Signed-off-by: MasterSkepticista <[email protected]>
Signed-off-by: MasterSkepticista <[email protected]>
Signed-off-by: MasterSkepticista <[email protected]>
we should also remove |
Also I see some of the places in few files where there is a comment it is used only in native api/interactive api. If that is the case, we should clean this dead code also. |
Yes, this will be addressed in future commits. PR is currently in draft (marked ready for CI checks). |
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
@MasterSkepticista Apart from this openfl/plugins/frameworks_adapters/framework_adapter_interface.py all other plugins are currently used for director and envoy. Also grpc director_server.py and director_client.py is used only in envoy and director. |
Yes, will remove in subsequent commits |
Signed-off-by: Shah, Karan <[email protected]>
…lan parsing code Signed-off-by: Shah, Karan <[email protected]>
cd63ff5
to
8efcc8a
Compare
Signed-off-by: Shah, Karan <[email protected]>
8efcc8a
to
d208600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, with a couple of comments/suggestions to consider:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR about? < PR title >
What changes have been made? < commit messages >
Tests done < CI status below >