introduce a mechanism for relearning the aggregator certificate #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Buchnik, Yehonatan <[email protected]>
Signed-off-by: Buchnik, Yehonatan <[email protected]>
teoparvanov
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Hi @yontyon , I have a couple of comments from my first review pass:
Signed-off-by: Buchnik, Yehonatan <[email protected]>
teoparvanov
reviewed
Jan 23, 2025
rahulga1
approved these changes
Jan 24, 2025
teoparvanov
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reality, the aggregator may restart and come up with new TLS certificate. For that, it is not enough to retry on the wrapper/interceptor level, but we also need to fetch the latest cert.
This PR introduces a mechanism for: