-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workflow] Add Phi-4 Finetuning Example #1308
Open
rajithkrishnegowda
wants to merge
28
commits into
securefederatedai:develop
Choose a base branch
from
rajithkrishnegowda:add_phi-4-model
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[workflow] Add Phi-4 Finetuning Example #1308
rajithkrishnegowda
wants to merge
28
commits into
securefederatedai:develop
from
rajithkrishnegowda:add_phi-4-model
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajithkrishnegowda
changed the title
WIP: Adding phi-4 model
WIP: Add phi-4 model to OpenFL
Jan 24, 2025
rajithkrishnegowda
force-pushed
the
add_phi-4-model
branch
from
January 24, 2025 12:18
4095bb9
to
c4eb107
Compare
rajithkrishnegowda
changed the title
WIP: Add phi-4 model to OpenFL
Add phi-4 model to OpenFL
Jan 24, 2025
rajithkrishnegowda
requested review from
psfoley,
teoparvanov,
MasterSkepticista,
rahulga1,
tanwarsh and
ishaileshpant
January 24, 2025 12:31
rahulga1
reviewed
Jan 24, 2025
porteratzo
reviewed
Jan 24, 2025
rahulga1
approved these changes
Jan 27, 2025
psfoley
reviewed
Jan 27, 2025
tanwarsh
reviewed
Jan 27, 2025
tanwarsh
approved these changes
Jan 27, 2025
MasterSkepticista
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why exactly do we need Gradio? How is it related to an FL tutorial?
- The PR description/title is misleading. Please rename as "[workflow] Add Phi-4 Finetuning Example"
- Consider asking the user to run
fx experimental activate
after installing OpenFL. This need not be part of the notebook execution cells.
rajithkrishnegowda
changed the title
Add phi-4 model to OpenFL
[workflow] Add Phi-4 Finetuning Example
Jan 28, 2025
|
payalcha
reviewed
Jan 28, 2025
payalcha
reviewed
Jan 28, 2025
|
|
changes made in 6ebb95e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is adding Phi-4 Finetuning workflow Example
Details: