-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODEOWNERS file for OpenFL repository #1309
Open
noopurintel
wants to merge
9
commits into
securefederatedai:develop
Choose a base branch
from
noopurintel:noopur/codeowners
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CODEOWNERS file for OpenFL repository #1309
noopurintel
wants to merge
9
commits into
securefederatedai:develop
from
noopurintel:noopur/codeowners
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noopurintel
changed the title
Draft: CODEOWNERS file for OpenFL repository
CODEOWNERS file for OpenFL repository
Jan 28, 2025
Signed-off-by: noopur <[email protected]>
payalcha
approved these changes
Jan 29, 2025
rahulga1
approved these changes
Jan 29, 2025
teoparvanov
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for kick-starting this effort, @noopurintel and @payalcha !
Signed-off-by: noopur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OpenFL repository currently lacks a
CODEOWNERS
file, which results in below (inter-related) issues:Inefficient code review process - without a
CODEOWNERS
file, there is no automatic mechanism to assign specific reviewers to pull requests. This can lead to delays in identifying the right people to review code changes, and may result in PRs being reviewed by individuals unfamiliar with the code they are reviewing.Increased risk of errors - without designated reviewers, code changes may bypass thorough review from subject matter experts, potentially leading to the introduction of bugs, security vulnerabilities, or performance issues.
Lack of Accountability - a missing
CODEOWNERS
file can make it unclear who should be held accountable for specific areas of the project. This can hinder communication and accountability within the development team.Proposed Solution
CODEOWNERS
file to address above issues and ensure that pull requests are automatically assigned to the relevant reviewers, improving the code review process, fostering accountability, and promoting better code quality.Key points
Permission – only people with write permissions can create/edit the file and be listed as code owners.
Syntax - follows simple text format, allows glob patterns. Similar to
.gitignore
file.PR review blocking
CODEOWNERS
file is present and relevant owners are not set to review a PR, GitHub will block the PR from being merged until required reviews are provided.CODEOWNERS
file, no reviewer will be automatically assigned for that file.Combination with branch protection rules - for example, you may require that a certain number of owners or specific team members approve PRs before they can be merged.
Pattern precedence
CODEOWNERS
file. The most specific pattern takes precedence over broader ones. For example, a pattern matching src/frontend/* will take precedence over src/*.Additional Info
GitHub clearly shows whether given CODEOWNERS file is valid or not, so it's easy to debug and fix it.
Even the owners with NO write permission would be marked as invalid entries.