Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Workspaces template #1314

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

tanwarsh
Copy link
Collaborator

@tanwarsh tanwarsh commented Jan 27, 2025

Changes required to recognise workspace in nested workspaces.
for example: Keras related workspace can be under keras folder in openFL workspace directory.

Copy link
Collaborator

@MasterSkepticista MasterSkepticista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do the same for torch?

Nitpick: fair to rename as keras/mnist, to make it agnostic to model. Toy examples can be any model, and likely keep changing.

Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Copy link
Collaborator

@MasterSkepticista MasterSkepticista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for propagating changes to torch. Before merge, recommend reviewing the documentation locally (i.e. with notebook execution enabled). We wouldn't want the notebook to fail post-merge.

Details to rebuild/test documentation: https://openfl.readthedocs.io/en/latest/contributing.html#update-documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants