chore: adapt runTest.js script to allow csaf 2.1 tests
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging 217-csaf-2.1-test-script into 196-csaf-2.1
Coverage Report |
tschmidtb51
reviewed
Feb 28, 2025
| @@ -3,44 +3,126 @@ | |||
| /** | |||
| * @file Script to validate JSON files against given tests | |||
| * | |||
| * Usage: node <script-path>.js json/file/path.json mandatoryTest_6_1_1 | |||
| * Usage: node <script-path>.js -f <json-file-path> -t <test-name> [-c <csaf-version>] | |||
There was a problem hiding this comment.
I'm not fully convinced about -c as short for CSAF version. I also wrote that in an different ticket (csaf-poc/csaf-rust#22). Given that this is a more generic process (which might take a little longer), I suggest to accept this as -c for now and fix it once the decision has be made.
Therefore, tracked as separate ticket #221
tschmidtb51
approved these changes
Feb 28, 2025
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #217 .