Thining results #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: code_reformat <>
mattj89
approved these changes
Jun 3, 2024
|
Also, you'll need to merge in some small changes from main before merging the pull request. Shouldn't be any conflicts. |
Signed-off-by: t.hajimohammadloo <[email protected]>
Signed-off-by: t.hajimohammadloo <[email protected]>
Signed-off-by: t.hajimohammadloo <[email protected]>
Signed-off-by: code_reformat <> Signed-off-by: t.hajimohammadloo <[email protected]>
… into thining_results
davidrandell84
force-pushed
the
thining_results
branch
from
f49d7b7 to
f4e24da
Compare
Signed-off-by: david.randell <[email protected]>
Signed-off-by: david.randell <[email protected]>
Signed-off-by: code_reformat <> Signed-off-by: david.randell <[email protected]>
Signed-off-by: bvandekerkhof <[email protected]> Signed-off-by: david.randell <[email protected]>
Signed-off-by: t.hajimohammadloo <[email protected]> Signed-off-by: david.randell <[email protected]>
Signed-off-by: t.hajimohammadloo <[email protected]> Signed-off-by: david.randell <[email protected]>
Signed-off-by: code_reformat <> Signed-off-by: t.hajimohammadloo <[email protected]> Signed-off-by: david.randell <[email protected]>
davidrandell84
force-pushed
the
thining_results
branch
from
f4e24da to
bc6aa1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added thinning to help the memory usage for large datasets by reducing output storage size by storing every k-th iteration instead of the full chain.
List any dependencies that are required for this change.
No dependencies.
Fixes # (issue)
Improving memory issue for larger cases.
Type of change
Please delete options that are not relevant.
Jupyter Notebooks
If your changes involve Jupyter notebooks please explicitly state here what the change consists of, e.g. only output
cells have changes or specific input changes. This to make sure we capture these changes correctly in the review process.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Updated existing test test_run_mcmc with additional input for thinning. We tested that the right number of sample function is called and the storage dictionary is in the right size.
As part of this we renamed the nburn_iter fixture to mcmc_setting to reflect the use of thinning parameter as well.
Checklist: