Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updating #22

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Package updating #22

merged 7 commits into from
Feb 12, 2025

Conversation

bvandekerkhof
Copy link
Collaborator

Description

Updating the version of outdated (required) packages and added fixes to deprecated functions, e.g. mapbox plots. Also indicating we are moving away from the pyelq-sdk project to pyelq.

Fixes #15

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Jupyter Notebooks

Updated the cells of the notebook to make sure it all still runs which it does. Cleared all output again after to avoid larger data volumes being pushed to git.

How Has This Been Tested?

No new tests have been implemented, only made sure to fix all existing tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@mattj89 mattj89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted existing venv and reinstalled using this branch version. All unit tests are passing, and the example notebook still functions as expected. Have not reviewed individual package-related code updates, but they look fine. Thanks.

@bvandekerkhof bvandekerkhof merged commit c1782ae into main Feb 12, 2025
16 checks passed
@bvandekerkhof bvandekerkhof deleted the package_updating branch February 12, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapbox renderer deprecated in Plotly v5.24
2 participants