Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SDK part #23

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Removing SDK part #23

merged 3 commits into from
Feb 18, 2025

Conversation

bvandekerkhof
Copy link
Collaborator

Description

Minor updates which make sure we move the code from the pyelq-sdk project to the pyelq project on pypi.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Jupyter Notebooks

No changes to notebooks

How Has This Been Tested?

No changes to the code, hence no new tests. All tests still run and pass as expected.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@bvandekerkhof bvandekerkhof requested a review from mattj89 February 7, 2025 14:55
Copy link
Collaborator

@mattj89 mattj89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good- thanks.

@bvandekerkhof bvandekerkhof merged commit 3787c4c into main Feb 18, 2025
9 checks passed
@bvandekerkhof bvandekerkhof deleted the removing_sdk_part branch February 18, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants