-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ add functions for collecting Sprout-specific package and resource errors [4/7] #964
Open
martonvago
wants to merge
7
commits into
feat/sprout-checks-3-required-and-blank-checks
Choose a base branch
from
feat/sprout-checks-4-sprout-specific-package-and-resource-errors
base: feat/sprout-checks-3-required-and-blank-checks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+286
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
changed the title
feat: ✨ add functions for collecting Sprout-specific package and resource errrors
feat: ✨ add functions for collecting Sprout-specific package and resource errors [4/7]
Jan 10, 2025
…at/sprout-checks-4-sprout-specific-package-and-resource-errors
…at/sprout-checks-4-sprout-specific-package-and-resource-errors
signekb
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work ⭐ Looking forward to getting to the next PRs.
…at/sprout-checks-4-sprout-specific-package-and-resource-errors
lwjohnst86
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'll merge this after the PR this is stacked on gets resolved. |
…at/sprout-checks-4-sprout-specific-package-and-resource-errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functions that collect Sprout-specific errors (i.e. violations of constraints other than those in the Data Package standard) after checking package and resource properties. These functions will be used together with check functions from the
checks
package to run all checks.This PR needs an in-depth review.
Checklist
just run-all