Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add functions for collecting Sprout-specific package and resource errors [4/7] #964

Open
wants to merge 7 commits into
base: feat/sprout-checks-3-required-and-blank-checks
Choose a base branch
from

Conversation

martonvago
Copy link
Contributor

@martonvago martonvago commented Jan 10, 2025

Description

This PR adds functions that collect Sprout-specific errors (i.e. violations of constraints other than those in the Data Package standard) after checking package and resource properties. These functions will be used together with check functions from the checks package to run all checks.

This PR needs an in-depth review.

Checklist

  • Added or updated tests
  • Updated documentation
  • Ran just run-all

@martonvago martonvago self-assigned this Jan 10, 2025
@martonvago martonvago changed the title feat: ✨ add functions for collecting Sprout-specific package and resource errrors feat: ✨ add functions for collecting Sprout-specific package and resource errors [4/7] Jan 10, 2025
@martonvago martonvago marked this pull request as ready for review January 10, 2025 23:21
@martonvago martonvago requested a review from a team as a code owner January 10, 2025 23:21
…at/sprout-checks-4-sprout-specific-package-and-resource-errors
…at/sprout-checks-4-sprout-specific-package-and-resource-errors
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ⭐ Looking forward to getting to the next PRs.

Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lwjohnst86
Copy link
Member

I'll merge this after the PR this is stacked on gets resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants