feat: ✨ add check_resource_properties [5/7] #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
commented
Jan 10, 2025
There was a problem hiding this comment.
This function is very similar to the other two top-level functions check_package_properties and check_properties (in other PRs). We can commonise some bits later if we want.
martonvago
changed the title
…ce-errors' into feat/sprout-checks-5-check-resource-properties
…ce-errors' into feat/sprout-checks-5-check-resource-properties
signekb
reviewed
Jan 15, 2025
seedcase_sprout/core/sprout_checks/check_resource_properties.py
Outdated
Show resolved
Hide resolved
tests/core/sprout_checks/test_check_resource_properties_sprout.py
Outdated
Show resolved
Hide resolved
signekb
reviewed
Jan 15, 2025
seedcase_sprout/core/sprout_checks/check_resource_properties.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
…ce-errors' into feat/sprout-checks-5-check-resource-properties
lwjohnst86
requested changes
Jan 20, 2025
seedcase_sprout/core/sprout_checks/check_resource_properties.py
Outdated
Show resolved
Hide resolved
tests/core/sprout_checks/test_check_resource_properties_sprout.py
Outdated
Show resolved
Hide resolved
…ce-errors' into feat/sprout-checks-5-check-resource-properties
Co-authored-by: Luke W. Johnston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the top-level check function for resource properties in Sprout.
It also adds a "summary" error that is raised when any specific
CheckErroris found by any of the inner check functions.Closes #937
This PR needs an in-depth review.
Checklist
just run-all