Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add check_properties [7/7] #967

Open
wants to merge 9 commits into
base: feat/sprout-checks-6-check-package-properties
Choose a base branch
from

Conversation

martonvago
Copy link
Contributor

@martonvago martonvago commented Jan 10, 2025

Description

This PR adds the top-level check function for package and resource properties combined (in Sprout).

This PR needs an in-depth review.

Checklist

  • Added or updated tests
  • Updated documentation
  • Ran just run-all

@martonvago martonvago self-assigned this Jan 10, 2025
@martonvago martonvago changed the title feat: ✨ add check_properties feat: ✨ add check_properties [7/7] Jan 10, 2025
@martonvago martonvago marked this pull request as ready for review January 10, 2025 23:21
@martonvago martonvago requested a review from a team as a code owner January 10, 2025 23:21
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😁

seedcase_sprout/core/sprout_checks/check_properties.py Outdated Show resolved Hide resolved
tests/core/sprout_checks/test_check_properties_sprout.py Outdated Show resolved Hide resolved
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like with other PRs, only a small suggestion

seedcase_sprout/core/sprout_checks/check_properties.py Outdated Show resolved Hide resolved
@martonvago martonvago requested a review from lwjohnst86 January 20, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants