Check access rule before updating class byte #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkCommand() shall be called before class byte is updated with the channel number. Otherwise, valid trasmit request can be filtered out becaue of the channel number. Say that the APDU filter "00 55 00 00" is available and the current channel number is 1, for example. The APDU header is changed to "01 xx xx xx" if the class byte is updated by Util.setChannelToClassByte(). In this case, the transmit request is incorrectly rejected because of the channel number if we do not apply this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkCommand() shall be called before class byte is updated with the
channel number. Otherwise, valid trasmit request can be filtered out
becaue of the channel number.
Say that the APDU filter "00 55 00 00" is available and the current
channel number is 1, for example. The APDU header is changed to "01 xx
xx xx" if the class byte is updated by Util.setChannelToClassByte(). In
this case, the transmit request is incorrectly rejected because of the
channel number if we do not apply this change.