Skip to content

Commit

Permalink
Version Packages (#1171)
Browse files Browse the repository at this point in the history
  • Loading branch information
seek-oss-ci authored Oct 24, 2022
1 parent bad6129 commit b97fa78
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 28 deletions.
27 changes: 0 additions & 27 deletions .changeset/blue-planes-draw.md

This file was deleted.

22 changes: 22 additions & 0 deletions packages/braid-design-system/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,27 @@
# braid-design-system

## 31.18.1

### Patch Changes

- **Button, ButtonLink:** Improve alignment of transparent buttons with icons against Text with icons ([#1170](https://github.com/seek-oss/braid-design-system/pull/1170))

To improve optical balance of a `Button` with an `icon`, the icon container is bled to the left to balance against the larger horizontal inset of a `standard` button.
This alignment correction is now only applied on `standard` sized buttons that are not using the `transparent` variant.

Isolating this alignment correction enables transparent buttons to better align with other components with `icon` slots, for example:

```jsx
<Stack space="small">
<Text icon={<IconSend />}>Text</Text>
<Button icon={<IconSend />} variant="transparent" bleed>
Button
</Button>
</Stack>
```

Icons and text will now be perfectly aligned between Button components and others icon slots with the same text size.

## 31.18.0

### Minor Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/braid-design-system/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "braid-design-system",
"version": "31.18.0",
"version": "31.18.1",
"description": "Themeable design system for the SEEK Group",
"main": "lib/components/index.ts",
"bin": {
Expand Down
12 changes: 12 additions & 0 deletions site/src/componentUpdates.json
Original file line number Diff line number Diff line change
Expand Up @@ -2701,5 +2701,17 @@
"summary": "Removes custom icon sizing and layout in favour of new typography icon sizes and layout."
}
]
},
{
"version": "31.18.1",
"updates": [
{
"updated": [
"Button",
"ButtonLink"
],
"summary": "**Button, ButtonLink:** Improve alignment of transparent buttons with icons against Text with icons\n\nTo improve optical balance of a `Button` with an `icon`, the icon container is bled to the left to balance against the larger horizontal inset of a `standard` button.\nThis alignment correction is now only applied on `standard` sized buttons that are not using the `transparent` variant.\n\nIsolating this alignment correction enables transparent buttons to better align with other components with `icon` slots, for example:\n\n```jsx\n<Stack space=\"small\">\n <Text icon={<IconSend />}>Text</Text>\n <Button icon={<IconSend />} variant=\"transparent\" bleed>\n Button\n </Button>\n</Stack>\n```\n\nIcons and text will now be perfectly aligned between Button components and others icon slots with the same text size."
}
]
}
]

0 comments on commit b97fa78

Please sign in to comment.