MenuRenderer, OverflowMenu: Ensure menus work in Modal components #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 14cc92f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
approved these changes
Dec 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where menus could be obscured when rendered inside a
DialogorDrawercomponent.MenuRendererand Modals are both in separate Braid portals, which are in the same stacking context. Hence, theirzIndexvalues are compared.MenuRendererpreviously had a lowerzIndexvalue than Modals, and hence if one was used in aModelit would be stacked incorrectly. As they now have the samezIndexvalue, the element later in the DOM is stacked above, which works correctly forMenusin and out ofModals.In this solution, the
zIndexvalue forMenuRendereris not semantically accurate. This should likely be revisited in the future to address this issue.