Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccordionItem: Fix issue parsing data props incorrectly #1680

Merged
merged 2 commits into from
Jan 12, 2025
Merged

AccordionItem: Fix issue parsing data props incorrectly #1680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bf1d81
AccordionItem: Fix issue parsing data props incorrectly
felixhabib Jan 8, 2025
3021e38
Merge branch 'master' into accordion-restprops-fix
felixhabib Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/big-toys-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'braid-design-system': patch
---

---
updated:
- AccordionItem
---

**AccordionItem**: Fix issue that caused `data` props to be incorrectly parsed, resulting in unexpected warnings.
9 changes: 2 additions & 7 deletions packages/braid-design-system/src/lib/components/Accordion/AccordionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ import {
AccordionContext,
validTones,
} from './AccordionContext';
import buildDataAttributes, {
type DataAttributeMap,
} from '../private/buildDataAttributes';
import type { DataAttributeMap } from '../private/buildDataAttributes';
import { badgeSlotSpace } from '../private/badgeSlotSpace';
import * as styles from './AccordionItem.css';
import { Spread } from '../Spread/Spread';
Expand Down Expand Up @@ -125,10 +123,7 @@ export const AccordionItem = ({
});

return (
<Stack
space={itemSpace}
{...buildDataAttributes({ data, validateRestProps: restProps })}
>
<Stack space={itemSpace} {...restProps}>
<Box position="relative" display="flex">
<Box
component="button"
Expand Down
Loading