Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use httpOnly cookies for authentication #59

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

anjula-sack
Copy link
Member

@anjula-sack anjula-sack commented Aug 14, 2023

Purpose

The purpose of this PR is to fix #60 and fix #61

Goals

To improve security by using httpOnly cookies

Approach

  • Update the auth to use httpOnly cookies
  • Add the logout endpoint

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Member

@Piumal1999 Piumal1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thank you @anjula-sack

@Piumal1999 Piumal1999 merged commit e308f8d into sef-global:main Aug 16, 2023
1 check passed
anjula-sack pushed a commit to anjula-sack/scholarx-backend that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the logout endpoint Implementation of HttpOnly cookies
2 participants