Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the footer thematic break in scholarx archive page #1590

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake commented Dec 28, 2023

Purpose

The purpose of this PR is to fix #1580

Goals

Fixing the footer thematic break in scholarx archive page

Approach

I removed the styles (margin: 0 !important;) given for the hr attribute in styles.css file

Screenshots

image

Preview Link

https://pr-1590-sef-site.surge.sh/scholarx/archive/

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Related PRs

Learning

Fix the footer thematic break in scholarx archive page
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @YoshithaRathnayake

@anjula-sack anjula-sack merged commit b63770f into master Dec 29, 2023
1 check passed
@YoshithaRathnayake YoshithaRathnayake deleted the scholarx-archive-hr branch December 29, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the footer thematic break in scholarx archive page
2 participants