Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Learn More button redirecting problem on the Join Us page #1617

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix the Learn More button redirecting problem on the Join Us page #1617

merged 1 commit into from
Apr 16, 2024

Conversation

RamithaHeshan33
Copy link
Contributor

@RamithaHeshan33 RamithaHeshan33 commented Apr 8, 2024

Purpose

Fixing the issue of "Learn More" button on the Join Us page opening in the same page #1612

Goals

After clicking the "Learn More" button handbook will open from new tab

Approach

Modified the "join-us.html" file. I used the attribute called "target='_blank' "

Screenshots

Screenshot 2024-04-08 202512

Preview Link

https://pr-1617-sef-site.surge.sh/

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copy link
Contributor Author

@RamithaHeshan33 RamithaHeshan33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoshithaRathnayake Can you check and review my PR.

@anjula-sack
Copy link
Member

@RamithaHeshan33 Can you drop a message on the relevant issue so i can assign you?

@YoshithaRathnayake
Copy link
Member

YoshithaRathnayake commented Apr 15, 2024

@YoshithaRathnayake Can you check and review my PR.

No problem in the PR btw, just put a comment on the issue to be assigned to this issue as @anjula-sack said @RamithaHeshan33

Development Best Practises If you read this you will find that first of all you should be assigned for a issue, bcs this is your first time its ok so just go to the issue and drop a comment that you are working on it!

@RamithaHeshan33
Copy link
Contributor Author

@RamithaHeshan33 Can you drop a message on the relevant issue so i can assign you?

Sure @anjula-sack. I created this pull request for issue number #1612 (Fix the "Learn More" button link on the Join Us page opening in the same page) I will add a screenshot of the issue below to make the problem more clear.

Screenshot 2024-04-16 125350

Before Fixing the Issue

before.mp4

After Fixing the Issue

after.mp4

@RamithaHeshan33
Copy link
Contributor Author

@YoshithaRathnayake Can you check and review my PR.

No problem in the PR btw, just put a comment on the issue to be assigned to this issue as @anjula-sack said @RamithaHeshan33

Development Best Practises If you read this you will find that first of all you should be assigned for a issue, bcs this is your first time its ok so just go to the issue and drop a comment that you are working on it!

Thanks for the reviewing PR @YoshithaRathnayake. Yes, it was my first time. Sorry for putting a pull request before assigning and Thank you for your guidance.

@YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake Can you check and review my PR.

No problem in the PR btw, just put a comment on the issue to be assigned to this issue as @anjula-sack said @RamithaHeshan33
Development Best Practises If you read this you will find that first of all you should be assigned for a issue, bcs this is your first time its ok so just go to the issue and drop a comment that you are working on it!

Thanks for the reviewing PR @YoshithaRathnayake. Yes, it was my first time. Sorry for putting a pull request before assigning and Thank you for your guidance.

No problem @RamithaHeshan33

@YoshithaRathnayake
Copy link
Member

So can you drop a comment in the issue #1612 otherwise I won't be able to assign you for the issue @RamithaHeshan33

@YoshithaRathnayake YoshithaRathnayake changed the title Fix the Learn More button link on the Join Us page opening in the sam… Fix the Learn More button redirecting problem on the Join Us page Apr 16, 2024
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job
Thank You! @RamithaHeshan33

@YoshithaRathnayake YoshithaRathnayake merged commit 69795d8 into sef-global:master Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants