Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justifying paragraphs on ScholarX 2023 #1619

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Justifying paragraphs on ScholarX 2023 #1619

merged 3 commits into from
Apr 26, 2024

Conversation

RamithaHeshan33
Copy link
Contributor

@RamithaHeshan33 RamithaHeshan33 commented Apr 24, 2024

Purpose

The purpose of this PR is to fix #1618

Goals

Justifying the two paragraphs related to the remaining two topics in the ScholarX web page

Approach

approach

Screenshots

Before Fixing the Issue

before1
before2

After Fixing the Issue

after1
after2

Preview Link

https://pr-1619-sef-site.surge.sh/scholarx

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Do you consider yourself a qualified professional with a knack for mentoring?
Now you can share your knowledge with budding young talent of Sri Lanka.
Reach us via <a
href="mailto:[email protected]">[email protected]</a>
Reach us via <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why did you add a line brake here? @RamithaHeshan33

Copy link
Contributor Author

@RamithaHeshan33 RamithaHeshan33 Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a line break, the result is like this.

Screenshot 2024-04-25 222140

That's why I used a line break here @YoshithaRathnayake

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the preview link? @RamithaHeshan33
You should include the pr number except this {PR_NUMBER} and include the directory also
Ex: https://pr-0000-sef-site.surge.sh/scholarx

@RamithaHeshan33
Copy link
Contributor Author

Can you update the preview link? @RamithaHeshan33 You should include the pr number except this {PR_NUMBER} and include the directory also Ex: https://pr-0000-sef-site.surge.sh/scholarx

Sorry, I forgot that... Now updated!! @YoshithaRathnayake

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!
Thank you @RamithaHeshan33

@YoshithaRathnayake YoshithaRathnayake merged commit cd812d9 into sef-global:master Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Justifying the paragraphs in ScholarX 2023
2 participants