Setting counting feature on projects section #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshithaRathnayake
requested changes
May 16, 2024
|
@YoshithaRathnayake can you check if this PR is ok now please? |
YoshithaRathnayake
previously requested changes
May 18, 2024
|
I think it's ok now. @YoshithaRathnayake |
@anjula-sack will review rest! @RamithaHeshan33 |
|
After this PR there is an error when click the scholarx card and again undo (return immediately before it redirects for the scholarx page) the scholarx logo of the card is hidden and the card's height is getting longer |
anjula-sack
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #1629
Goals
Setting the counting feature on our projects section
Approach
update the index.html file
Screenshots
Before fixing the issue
After fixing the issue
after.mp4
Preview Link
https://pr-1630-sef-site.surge.sh/
Checklist