Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abort-controller package in favor of built-in AbortController #2722

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

sayan-das-in
Copy link
Contributor

@sayan-das-in sayan-das-in commented Feb 4, 2025

This PR removes the abort-controller package in favor of built-in support for AbortController.

Experimental support AbortController support was added in node 14.17.0 (ref)
This feature became stable in 15.4.0 (ref)
We are currently on version 18.12.1

Testing

We have a Unit test here to explicitly test the behavior of AbortController.
Tested E2E in Staging and Local.
Hadron dashboard is available here.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (52537f3) to head (32d73b6).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2722      +/-   ##
==========================================
+ Coverage   78.46%   79.22%   +0.75%     
==========================================
  Files        1036     1284     +248     
  Lines       18771    24688    +5917     
  Branches     3561     5097    +1536     
==========================================
+ Hits        14729    19558    +4829     
- Misses       2844     3925    +1081     
- Partials     1198     1205       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segmentio segmentio deleted a comment from github-actions bot Feb 4, 2025
@sayan-das-in
Copy link
Contributor Author

There are 2 unit tests in HubSpot and Amazon AMC where snapshot of response.options is recorded. This results in inconsistent behavior as it exposes all classes and functions on the Response object. This PR fixes those tests as well.

@sayan-das-in
Copy link
Contributor Author

Hadron shows some diffs but those looks to be false positives.

@maryamsharif maryamsharif merged commit 994371f into main Feb 4, 2025
14 checks passed
@maryamsharif maryamsharif deleted the remove-abort-controller branch February 4, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants