Simplifies type generation for hooks #2723
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue that came up when adding object type hook input fields. The type generation couldn't properly define the nested shape of the properties and would incorrectly generate something like this:
In general the
HookBundle
previously would have a shape such as this:And I've updated it to flatter shape which cleanly generates nested object properties like this:
Testing
This change should be non-functional, since it only applies to action hook types.
Tested successfully in stage against LinkedIn Conversions API: Could successfully create a Conversion rule with the actions onMappingSave hook