Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node engine requirements to ^18.12 || ^22.13 #2730

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Upgrade Node engine requirements to ^18.12 || ^22.13 #2730

wants to merge 6 commits into from

Conversation

sayan-das-in
Copy link
Contributor

@sayan-das-in sayan-das-in commented Feb 10, 2025 •
edited
Loading

This PR introduces the following changes

  1. Upgrades Node engine requirements to ^18.12 || ^22.13
  2. Upgrades dependencies that causes issue yarn install and to fail on node 22.13
  3. Fixes build issues with PipeDrive destination that causes yarn build to fail on node 22.13
  4. Simplifies Node upgrade #2706 PR.

List of Dependency upgrades

  1. @types/node - ^18.11.15 -> ^18.11.15
  2. typescript - 4.3.5 -> 4.9.5
  3. ssh2-sftp-client - 9.1.0 -> 10.0.3

Testing

Tested locally with unit tests

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@sayan-das-in sayan-das-in requested review from a team as code owners February 10, 2025 09:57
itsarijitray
itsarijitray previously approved these changes Feb 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsarijitray itsarijitray itsarijitray left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
actions:core mode:cloud mode:device team:segment-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayan-das-in @itsarijitray