fix encoding RawMessage that contains leading space #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extemporalgenome
changed the title
nainya
reviewed
Nov 27, 2023
| @@ -19,7 +19,7 @@ test-json: | |||
| go test -cover -race ./json | |||
|
|
|||
| test-json-bugs: | |||
| go test -cover -race ./json/bugs/... | |||
| go test -race ./json/bugs/... | |||
There was a problem hiding this comment.
Any reason for removing the coverage for this run?
There was a problem hiding this comment.
Got reply over slack: https://twilio.slack.com/archives/G01CPV0P0SE/p1701104274453339?thread_ts=1701100801.803679&cid=G01CPV0P0SE
Coverage is non-applicable, since it only covers non-test code in the same package. Since those bug packages have no non-test code, sampling coverage has no benefit.
I'm pretty sure whomever set up the makefile just copy-pasted the same command to each target
nainya
approved these changes
Nov 27, 2023
nanomosfet
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library currently returns a syntax error when asked to encode
a RawMessage that happens to contain leading space byte(s).
Since some space bytes are valid JSON, these should be accepted.
This behavior also deviates from the stdlib,
which does not assume that a provided RawMessage is free of leading spaces.