Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #429 respin making reader.read respect context closure #1347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zekth
Copy link

@zekth zekth commented Nov 14, 2024

fix: #428

This is a respin of #429 with added benchmarks like the review asked for.

MAIN
BenchmarkReaderClose-14    	       1	1001178125 ns/op	   55016 B/op	     429 allocs/op

Branch
BenchmarkReaderClose-14                1        1001329375 ns/op           56120 B/op        434 allocs/op

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@zekth
Copy link
Author

zekth commented Nov 14, 2024

@achille-roussel could you please look at this?

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader.Close hangs for ReaderConfig.MaxWait
1 participant