Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best Practices for Custom Domains #7114

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Best Practices for Custom Domains #7114

merged 3 commits into from
Oct 10, 2024

Conversation

joeynmq
Copy link
Contributor

@joeynmq joeynmq commented Oct 4, 2024

Proposed changes

We have been asked several times about setting up multiple custom domains for sources/environments/domains. So would like to add the best practices to the FAQ section for some clarifications.

Merge timing

ASAP once approved

Related issues (optional)

https://segment.atlassian.net/browse/KCS-1699

@joeynmq joeynmq marked this pull request as ready for review October 9, 2024 00:06
@joeynmq joeynmq requested a review from a team as a code owner October 9, 2024 00:06
wally-tg
wally-tg previously approved these changes Oct 9, 2024
@forstisabella forstisabella merged commit 3c25c99 into develop Oct 10, 2024
4 checks passed
@forstisabella forstisabella deleted the joeynmq-patch-2 branch October 10, 2024 15:03
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants