Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite RETL model resource schedule values even if null #162

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

deanhuynh
Copy link
Contributor

Since these fields are deprecated and no longer passed to Public API, we are overwriting them with whatever the previous value was to prevent recurring diffs. This has no impact on actual applies since this field is ignored, but it was confusing to see the diff continually pop up.

This prevents changes like this from recurring:

Terraform will perform the following actions:

  # segment_reverse_etl_model.example will be updated in-place
  ~ resource "segment_reverse_etl_model" "example" {
        id                      = "abc123"
        name                    = "name"
      - schedule_config         = jsonencode({})
        # (5 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Addresses #160

@deanhuynh deanhuynh requested a review from a team as a code owner January 6, 2025 20:02
@deanhuynh deanhuynh merged commit e5f0d16 into main Jan 6, 2025
17 checks passed
@deanhuynh deanhuynh deleted the APICS-2868/retl-constant-diffs branch January 6, 2025 21:37
@deanhuynh deanhuynh mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants