-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CT Transfer types #1899
base: main
Are you sure you want to change the base?
CT Transfer types #1899
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
+ Coverage 61.35% 61.37% +0.01%
==========================================
Files 263 267 +4
Lines 23328 23798 +470
==========================================
+ Hits 14314 14606 +292
- Misses 8009 8133 +124
- Partials 1005 1059 +54
|
This LGTM so far, to summarize my understanding here:
Does this sound right? Questions:
|
) | ||
|
||
func TestMsgTransfer_FromProto(t *testing.T) { | ||
testDenon := "factory/sei1ft98au55a24vnu9tvd92cz09pzcfqkm5vlx99w/TEST" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testDenom*
|
||
remainingBalance := uint64(200) | ||
|
||
// Encrypt the amount using source and destination public keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to make this its own function?
func ToProto(transfer *Transfer) *MsgTransfer {}
* scaffolding for new module * keeper scaffolding * scaffold with types * go sum * comments pt1 * comments * drop prev580
* pending balance type * convert apply pending balance to a message type * close account type
* new types * add deposit to msgs * add import issues * revert evm/params to old state * withdraw with tests * small changes * refactor and add tests * comment
Describe your changes and provide context
This PR contains transfer types to support confidential transfers feature
Testing performed to validate your change