make build possible on 7.2 and up... #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i reviewed and tested, seems build and works with php7.2, travis test said fails two checks: FAIL session id too long [tests/session/max_id_length_toolong.phpt] seems are very important the test failed but in certaint environment does not fail! |
|
i've seen this test, i've not investigated why session id has changed in size... possible 7.2 session hash size as differente size for now... when i've some time i while investigade in the code why. |
|
maybe will be necessary ask to php developers directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now suhosin7 not build on php 7.2, this patch make possible to build on 7.2 and up...