Fix unknown read in TelnetLayer (#1534)

* Fix unknown read in TelnetLayer * need at least 2 bytes for command * fix formatting --------- Co-authored-by: Liu, An-Chi <[email protected]>
seladb · Aug 14, 2024 · 6627ab7 · 6627ab7
1 parent 0cc772e
commit 6627ab7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Packet++/src/TelnetLayer.cpp b/Packet++/src/TelnetLayer.cpp
@@ -92,7 +92,8 @@ namespace pcpp
 			pos += length;
 			offset += length;
 
-			if (isCommandField(pos))
+			if ((static_cast<size_t>(pos - m_Data) <= (m_DataLen - 2)) &&
+			    isCommandField(pos))  // Need at least 2 bytes for command
 				return pos;
 		}
 

diff --git a/...essionTests/regression_samples/clusterfuzz-testcase-minimized-FuzzTarget-4981601846820864 b/...essionTests/regression_samples/clusterfuzz-testcase-minimized-FuzzTarget-4981601846820864