Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert of #1647 #1691

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Revert of #1647 #1691

wants to merge 4 commits into from

Conversation

Dimi1010
Copy link
Collaborator

This PR reverts the formatting changes made in #1647.

The reason for the revert is issues with #1659. Verbatim blocks have issues parsing with the /// syntax. And since the PRs are linked, decided it was better to revert to the /** structure than risk breaking the documentation.

This reverts commit f81ced2.

…1647)"

This reverts commit f81ced2.

# Conflicts:
#	Common++/header/IpAddress.h
#	Common++/header/IpUtils.h
#	Common++/header/LRUList.h
#	Common++/header/Logger.h
#	Common++/header/MacAddress.h
#	Common++/header/OUILookup.h
#	Common++/header/PointerVector.h
#	Common++/header/SystemUtils.h
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (d60c699) to head (1dc42fa).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1691      +/-   ##
==========================================
- Coverage   83.11%   83.10%   -0.02%     
==========================================
  Files         277      277              
  Lines       48207    48207              
  Branches    10192     9948     -244     
==========================================
- Hits        40069    40064       -5     
- Misses       7243     7248       +5     
  Partials      895      895              
Flag Coverage Δ
alpine320 75.10% <0.00%> (-0.01%) ⬇️
fedora40 75.13% <0.00%> (-0.04%) ⬇️
macos-13 80.61% <100.00%> (-0.01%) ⬇️
macos-14 80.61% <100.00%> (-0.01%) ⬇️
macos-15 80.59% <100.00%> (ø)
mingw32 70.82% <0.00%> (-0.05%) ⬇️
mingw64 70.80% <0.00%> (-0.03%) ⬇️
npcap 85.24% <100.00%> (-0.02%) ⬇️
rhel94 74.97% <0.00%> (-0.01%) ⬇️
ubuntu2004 58.56% <0.00%> (-0.03%) ⬇️
ubuntu2004-zstd 58.71% <0.00%> (+0.02%) ⬆️
ubuntu2204 74.90% <0.00%> (-0.01%) ⬇️
ubuntu2204-icpx 61.45% <100.00%> (+<0.01%) ⬆️
ubuntu2404 75.15% <0.00%> (-0.01%) ⬇️
unittest 83.10% <100.00%> (-0.02%) ⬇️
windows-2019 85.27% <100.00%> (-0.01%) ⬇️
windows-2022 85.30% <100.00%> (-0.01%) ⬇️
winpcap 85.26% <100.00%> (ø)
xdp 50.52% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimi1010 Dimi1010 marked this pull request as ready for review January 17, 2025 23:32
@Dimi1010 Dimi1010 requested a review from seladb as a code owner January 17, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant