Fix getCommandOption for command-only packets #1718
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pcap++ crashes when you attempt to getCommandOption() of a command-only FTP request packet. I traced the issue to SingleCommandTextProtocol::getCommandOptionInternal().
To check for command-only packets, it compares the offset to the option field returned by getArgumentFieldOffset() to the raw data length minus 1. This should be minus 2;
This PR makes the necessary change in SingleCommandTextProtocol.cpp and adds a command-only FTP request packet testcase to Packet++Test