Merge pull request #29 from shashank-saxena/master

Check for called function exports
selaux · Jun 8, 2018 · 0833a43 · 0833a43
2 parents bb49b4a + f54fab9
commit 0833a43
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/lib/common/getExportedName.js b/lib/common/getExportedName.js
@@ -6,6 +6,10 @@ function getNodeName(node) {
     if (node.id && node.id.type === "Identifier") {
         return node.id.name;
     }
+
+    if (node.type === "CallExpression" && node.callee.type === "Identifier") {
+      return node.callee.name;
+    }
 }
 
 module.exports = function getExportedName(programNode) {

diff --git a/test/rules/match-exported.js b/test/rules/match-exported.js
@@ -7,6 +7,8 @@ var testCode = "var foo = 'bar';",
     exportedJsxClassCode = "module.exports = class Foo { render() { return <span>Test Class</span>; } };",
     exportedClassCode = "module.exports = class Foo {};",
     exportedFunctionCode = "module.exports = function foo() {};",
+    exportUnnamedFunctionCode = "module.exports = function() {};",
+    exportedCalledFunctionCode = "module.exports = foo();",
     exportedJsxFunctionCode = "module.exports = function foo() { return <span>Test Fn</span> };",
     exportedEs6VariableCode = "export default exported;",
     exportedEs6ClassCode = "export default class Foo {};",
@@ -30,13 +32,17 @@ ruleTester.run("lib/rules/match-exported", exportedRule, {
             code: testCode,
             filename: "<input>"
         },
+        {
+            code: exportUnnamedFunctionCode,
+            filename: "testFile.js"
+        },
         {
             code: testCode,
             filename: "/some/dir/exported.js"
         },
         {
             code: testCallCode,
-            filename: "/some/dir/exported.js",
+            filename: "/some/dir/foo.js",
             parserOptions: { ecmaVersion: 6, sourceType: "module" }
         },
         {
@@ -57,6 +63,10 @@ ruleTester.run("lib/rules/match-exported", exportedRule, {
             code: exportedFunctionCode,
             filename: "/some/dir/foo.js"
         },
+        {
+            code: exportedCalledFunctionCode,
+            filename: "/some/dir/foo.js"
+        },
         {
             code: exportedJsxFunctionCode,
             filename: "/some/dir/foo.js",
@@ -142,6 +152,13 @@ ruleTester.run("lib/rules/match-exported", exportedRule, {
                 { message: "Filename 'bar' must match the exported name 'foo'.", column: 1, line: 1 }
             ]
         },
+        {
+            code: exportedCalledFunctionCode,
+            filename: "/some/dir/bar.js",
+            errors: [
+                { message: "Filename 'bar' must match the exported name 'foo'.", column: 1, line: 1 }
+            ]
+        },
         {
             code: exportedJsxFunctionCode,
             filename: "/some/dir/bar.js",