Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#36: Feature Request: Do not apply match-exported if file is index.js #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bodawei
Copy link

@bodawei bodawei commented Apr 7, 2019

Request

In issue 36, I wrote:

The organization I work for has a rule very similar to what match-exported provides, except that we do not want exports from an index.js file to need to match the directory name.
We'd love to have something like another option to match-exported which would allow us to ask that it ignore index.js files.

Offered Implementation

This PR include an implementation that addresses the request. It adds an additional option that, when set to true, will cause match-exported to ignore index.js files.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dd66921 on bodawei:issue36 into 9cdf56a on selaux:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dd66921 on bodawei:issue36 into 9cdf56a on selaux:master.

@bodawei
Copy link
Author

bodawei commented Apr 13, 2019

Nudge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants