Minor alterations

.github/workflows/publish_release.yaml

@@ -6,7 +6,7 @@ name: Publish release
 
 on:
   release:
-    types: [ published ]
+    types: [ created ]
   workflow_dispatch:
 
 jobs:

addons/gst-web/src/app.js

@@ -237,7 +237,7 @@ var app = new Vue({
         },
         videoFramerate(newValue) {
             if (newValue === null) return;
-            console.log("video frame rate changed to " + newValue);
+            console.log("video framerate changed to " + newValue);
             webrtc.sendDataChannelMessage('_arg_fps,' + newValue);
             this.setIntParam("videoFramerate", newValue);
         },

addons/gst-web/src/index.html

@@ -145,7 +145,7 @@
                         {{ connectionVideoBitrate }}
                       </v-progress-circular>
                     </template>
-                    <span>Current video bit rate in mbps vs selected bit rate {{ (videoBitRate / 1000).toFixed(0) }}
+                    <span>Current video bitrate in mbps vs selected bitrate {{ (videoBitRate / 1000).toFixed(0) }}
                       mbps</span>
                   </v-tooltip>
 
@@ -264,17 +264,17 @@
                 </v-toolbar>
               </p>
               <p>
-                <v-select :items="videoBitRateOptions" label="Video bit rate" menu-props="left" v-model="videoBitRate"
-                  hint="Dynamic bit rate selection for hardware encoder on server" persistent-hint></v-select>
+                <v-select :items="videoBitRateOptions" label="Video bitrate" menu-props="left" v-model="videoBitRate"
+                  hint="Dynamic bitrate selection for host video encoder" persistent-hint></v-select>
               </p>
               <p>
-                <v-select :items="videoFramerateOptions" label="Video frame rate" menu-props="left"
-                  v-model="videoFramerate" hint="Frame rate selection, will reload window on change" persistent-hint>
+                <v-select :items="videoFramerateOptions" label="Video framerate" menu-props="left"
+                  v-model="videoFramerate" hint="Framerate selection for host video encoder" persistent-hint>
                 </v-select>
               </p>
               <p>
-                <v-select :items="audioBitRateOptions" label="Audio bit rate" menu-props="left" v-model="audioBitRate"
-                  hint="streaming bit rate selection for audio encoder on server"
+                <v-select :items="audioBitRateOptions" label="Audio bitrate" menu-props="left" v-model="audioBitRate"
+                  hint="Streaming bitrate selection for host audio encoder"
                   persistent-hint>
                 </v-select>
               </p>
@@ -294,15 +294,15 @@
                 <li>Video encoder: <b>{{ encoderName }}</b></li>
                 <li>Window size: <b>{{ windowResolution[0] }}x{{ windowResolution[1] }}</b></li>
                 <li>Video decoder: <b>{{ connectionVideoDecoder }}</b></li>
-                <li>Frame rate: <b>{{ connectionFrameRate }} fps</b></li>
-                <li>Bit rate: <b>{{ connectionVideoBitrate }} mbps</b></li>
+                <li>Framerate: <b>{{ connectionFrameRate }} fps</b></li>
+                <li>Bitrate: <b>{{ connectionVideoBitrate }} mbps</b></li>
                 <li>Available receive bandwidth: <b>{{ connectionAvailableBandwidth }}</b></li>
               </ul>
               Audio Stats
               <ul>
                 <li>Latency: <b>{{ connectionAudioLatency }} ms</b></li>
                 <li>Codec: <b>{{ connectionAudioCodecName }}</b></li>
-                <li>Bit rate: <b>{{ connectionAudioBitrate }} kbps</b></li>
+                <li>Bitrate: <b>{{ connectionAudioBitrate }} kbps</b></li>
               </ul>
               </p>
               <hr />

src/selkies_gstreamer/gstwebrtc_app.py

@@ -231,7 +231,7 @@ def build_video_pipeline(self):
 
             # Rate control mode tells the encoder how to compress the frames to
             # reach the target bitrate. A Constant Bit Rate (CBR) setting is best
-            # for streaming use cases as bit rate is the most important factor.
+            # for streaming use cases as bitrate is the most important factor.
             # A Variable Bit Rate (VBR) setting tells the encoder to adjust the
             # compression level based on scene complexity, something not needed
             # when streaming in real-time.
@@ -242,7 +242,7 @@ def build_video_pipeline(self):
             # Infinite GOP is best for streaming because it reduces the number
             # of large I-Frames being transmitted. At higher resolutions, these
             # I-Frames can dominate the bandwidth and add additional latency.
-            # With infinite GOP, you can use a higher bit rate to increase quality
+            # With infinite GOP, you can use a higher bitrate to increase quality
             # without a linear increase in total bandwidth.
             # A negative consequence when using infinite GOP size is that
             # when packets are lost, it may take the decoder longer to recover.
@@ -880,10 +880,10 @@ def send_reload_window(self):
             "system", {"action": "reload"})
 
     def send_framerate(self, framerate):
-        """Sends the current frame rate to the data channel
+        """Sends the current framerate to the data channel
         """
 
-        logger.info("sending frame rate")
+        logger.info("sending framerate")
         self.__send_data_channel_message(
             "system", {"action": "framerate,"+str(framerate)})