Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell support (config, workflow to detect/not fix) and make it fix few typos #162

Closed
wants to merge 3 commits into from

Conversation

yarikoptic
Copy link

More about codespell: https://github.com/codespell-project/codespell .

I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.

CI workflow has 'permissions' set only to 'read' so also should be safe.

@ehfd
Copy link
Member

ehfd commented Jul 28, 2024

Thanks for your recommendation, and I'm putting information about this on the development.md style guide as a recommended procedure for contributions.

However, it seems that codespell is not 100% accurate at all times, requiring manual approval, and since it's going to have read permissions only, I would prefer to leave it for individual developers to run in their pull requests instead of the CI.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@ehfd
Copy link
Member

ehfd commented Jul 28, 2024

I've fixed all the typos thanks to your PR and added adequate instructions about using codespell for developers. Because I'd like to constrain CI/CD pipelines to those that are automatic, I'll postpone the PR which adds the CI for now.

@ehfd ehfd closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants