Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: version bump README and setup.py #14

Merged
merged 2 commits into from
Aug 7, 2024
Merged

chore: version bump README and setup.py #14

merged 2 commits into from
Aug 7, 2024

Conversation

akuhlens
Copy link
Contributor

@akuhlens akuhlens commented Aug 7, 2024 •
edited
Loading

  1. This should land
  2. we should tag v1.84.0
    • git tag v1.84.0 <merged pr commit tag>
    • git push origin tag v1.84.0
  3. Then land the update to CI in chore: bump ci version to 1.84.0 #15

@akuhlens akuhlens mentioned this pull request Aug 7, 2024
Merged
kopecs
kopecs approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@kopecs kopecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm mod instructions in the PR comment (wrong version is listed there)

@akuhlens
Copy link
Contributor Author

akuhlens commented Aug 7, 2024 •
edited
Loading

lgtm mod instructions in the PR comment (wrong version is listed there)

Copy and paste error. Thanks for pointing that out before I copied those instructions.

@akuhlens akuhlens merged commit bbc390b into develop Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kopecs kopecs kopecs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akuhlens @kopecs