-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP docs: Update contribution guidelines #132
Open
sevilayerkan
wants to merge
3
commits into
senchabot-opensource:dev
Choose a base branch
from
sevilayerkan:pr-guide
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
<!-- | ||
Thank you for contributing to Senchabot! 🍵 | ||
|
||
Before opening this PR please make sure you've read the contribution guideline. | ||
|
||
Describe why this Pull Request needs to be merged. What bug have you fixed? What feature have you added? Why is it important? | ||
|
||
If you are fixing a specific issue, include "Fixes #ISSUE" (replace with the issue number, remove the quotes) and the issue will be linked to this PR. | ||
|
||
--> | ||
|
||
**This PR Closes:** | ||
|
||
<!-- If there's an existing issue for your change, please link to it below.--> | ||
|
||
A clear and concise description of which issue this PR closes. (You can tag issues by writing `#issuenum`) [REPLACE ME] | ||
|
||
**What's being changed in this PR (if available, include any code snippets, screenshots, or gifs)** | ||
|
||
<!-- Let us know what you are changing. Share anything that could provide the most context. --> | ||
|
||
A clear and concise description of what's being changed. [REPLACE ME] | ||
|
||
--- | ||
|
||
### Checklist | ||
|
||
Before submitting the PR make sure the following are checked: | ||
|
||
* [ ] I've checked [contribution guide](../../CONTRIBUTING.md) | ||
* [ ] I've created new branch in my fork for this PR. | ||
* [ ] For content changes, I have completed the [self-review checklist](self_review.md). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
## Self review | ||
|
||
You should always review your own PR first. | ||
|
||
For changes, make sure that you: | ||
|
||
- [ ] Confirm the changes you made adheres to [contribution guide](../../CONTRIBUTING.md). | ||
- [ ] Please be sure you've created a new branch in your fork for this PR. | ||
- [ ] Pull Request should be related to one change. Changes that are unrelated should be opened in separate PRs. | ||
- [ ] Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable. | ||
- [ ] Confirm that the changes meet the user experience and goals outlined in the content design plan (if there is one). | ||
- [ ] Review the content for technical accuracy. | ||
- [ ] Copy-edit the changes for grammar, spelling, and syntax errors. | ||
- [ ] If there are any failing checks in your PR, troubleshoot them until they're all passing. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CONTRIBUTING.md file location correct here? When I try to access this file, I get a
File not found
page.