fix: Ignore submodules in test directory #1071
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they are not installed under test folder in python site-packages
Also remove the temp*.py exclusion as this does not seem to have any purpose
Fixes
Installing sendgrid will also install test folder, with two sub folders in site-packages. This can create conflicts at worst and creates noise at best. Currently test folder is ignore in find_packages, but tests have been split into sub-modules and the find_packages exclude attribute was not updasted.
To test, install current main branch. Confirm test folder is in site-packages. Uninstall sendgrid, delete test folder in site-packages, delete *.egg-info folder, delete build folder, reinstall. test folder is no longer installed
Checklist
If you have questions, please file a support ticket.