Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor feedback dialog component to include success alert and separate form dialog children #28

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

sensasi-delight
Copy link
Owner

Previously, the feedback dialog component was refactored to include a separate success alert component and a separate component for the form dialog children. This improves code organization, reusability, readability, and maintainability. The form submission logic was also updated to handle form validation and submission. Now, when feedback is successfully submitted, a confirmation message is displayed using the success alert component.

…ate form dialog children

- Extracted the success alert component from the feedback dialog component to improve code organization and reusability.
- Created a separate component for the form dialog children to improve readability and maintainability.
- Added a success alert to display a confirmation message when feedback is successfully submitted.
- Updated the form submission logic to handle form validation and submission.
@sensasi-delight sensasi-delight merged commit cba6e08 into main Oct 12, 2024
2 checks passed
@sensasi-delight sensasi-delight deleted the feedback branch October 12, 2024 20:41
Copy link

Visit the preview URL for this PR (updated for commit 2927574):

https://simulasi-grading-sawit--pr28-feedback-lqozqkze.web.app

(expires Sat, 19 Oct 2024 20:42:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 31f78b17daf93f40a84a3fa2f04bdf2a5a38b335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant