Skip to content

Commit

Permalink
Merge pull request #72 from jakzal/revert-deprecated-page-object-aware
Browse files Browse the repository at this point in the history
Revert PageObjectAware deprecation
  • Loading branch information
jakzal authored Jun 12, 2016
2 parents 2e6b379 + 19d481a commit b07ebd6
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 25 deletions.
6 changes: 0 additions & 6 deletions doc/guide/working_with_page_objects.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@ with a type hint:
Using the page object factory
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.. note::

``PageObjectContext`` described here is deprecated in favour of
injecting page objects directly into context's constructor (described in the previous section).
``PageObjectContext`` will be removed in future versions of this extension.

Pages are created with a built in factory. One of the ways to use them in your
context is to call the ``getPage`` method provided by the
``SensioLabs\Behat\PageObjectExtension\Context\PageObjectContext``:
Expand Down
1 change: 0 additions & 1 deletion features/changing_page_object_namespaces.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@deprecated
Feature: Changing page object namespaces
In order to organise my code better
As a Developer
Expand Down
1 change: 0 additions & 1 deletion features/injecting_the_page_object_factory.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@deprecated
Feature: Injecting a page object factory
In order to avoid extending third-party contexts
As a Developer
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@deprecated
Feature: Providing a custom class name resolver for the default page object factory
In order to customise the way page object class names are resolved
As an Experienced Developer
Expand Down
1 change: 0 additions & 1 deletion features/using_page_objects_with_a_factory.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@deprecated
Feature: Using page objects with a factory
In order to keep my context files maintainable
As a Developer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,11 @@

namespace SensioLabs\Behat\PageObjectExtension\Context\Initializer;

@trigger_error('The '.__NAMESPACE__.'\PageObjectAwareInitializer class is deprecated since version 2.0 and will be removed in 3.0. Use the argument injection instead.', E_USER_DEPRECATED);

use Behat\Behat\Context\Context;
use Behat\Behat\Context\Initializer\ContextInitializer;
use SensioLabs\Behat\PageObjectExtension\Context\PageObjectAware;
use SensioLabs\Behat\PageObjectExtension\PageObject\Factory as PageObjectFactory;

/**
* @deprecated in 2.0, to be removed in 3.0. Use the argument resolver instead. See http://behat-page-object-extension.readthedocs.org/en/latest/guide/working_with_page_objects.html#instantiating-a-page-object
*/
class PageObjectAwareInitializer implements ContextInitializer
{
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,8 @@

namespace SensioLabs\Behat\PageObjectExtension\Context;

@trigger_error('The '.__NAMESPACE__.'\PageObjectAware interface is deprecated since version 2.0 and will be removed in 3.0. Use the argument injection instead.', E_USER_DEPRECATED);

use SensioLabs\Behat\PageObjectExtension\PageObject\Factory as PageObjectFactory;

/**
* @deprecated in 2.0, to be removed in 3.0. Use the argument resolver instead. See http://behat-page-object-extension.readthedocs.org/en/latest/guide/working_with_page_objects.html#instantiating-a-page-object
*/
interface PageObjectAware
{
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,11 @@

namespace SensioLabs\Behat\PageObjectExtension\Context;

@trigger_error('The '.__NAMESPACE__.'\PageObjectContext class is deprecated since version 2.0 and will be removed in 3.0. Use the argument injection instead.', E_USER_DEPRECATED);

use Behat\Behat\Context\Context;
use SensioLabs\Behat\PageObjectExtension\PageObject\Factory as PageObjectFactory;
use SensioLabs\Behat\PageObjectExtension\PageObject\Page;
use SensioLabs\Behat\PageObjectExtension\PageObject\Element;

/**
* @deprecated in 2.0, to be removed in 3.0. Use the argument resolver instead. See http://behat-page-object-extension.readthedocs.org/en/latest/guide/working_with_page_objects.html#instantiating-a-page-object
*/
class PageObjectContext implements Context, PageObjectAware
{
/**
Expand Down

0 comments on commit b07ebd6

Please sign in to comment.