adding cert option to some checks and metrics #101

csoleimani · 2017-11-29T08:59:59Z

Pull Request Checklist

Is this in reference to an existing issue?
kind of. #100

it's better to pass in a cert than not check for validation

General

Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass

New Plugins

Tests
Add the plugin to the README
Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

majormoses · 2017-12-03T00:24:47Z

Let me know if you need help working through the rubocop errors.

csoleimani · 2017-12-26T21:18:27Z

Sure, some help would be great. I tried running the autofix flag, but it just created some more issues. I'm not very familiar with Ruby and don't know all the best practices

majormoses · 2017-12-29T23:24:35Z

I went through the cops one by one, in some cases they were rather opinionated other places we should certainly refactor at a later date.

majormoses · 2017-12-29T23:33:44Z

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

majormoses

Overall this looks great, there are a few things that can be improved as well as some missing bits.

Missing bits:

changelog entry explaining the new feature
a testing artifact

As per my comment here we should probably add some documentation about the dangers of providing secrets directly to the CLI.

majormoses · 2017-12-29T23:25:33Z

Rakefile

@@ -36,4 +36,4 @@ task :check_binstubs do
  end
 end

-task default: [:spec, :make_bin_executable, :yard, :rubocop, :check_binstubs]
+task default: %i(spec make_bin_executable yard rubocop check_binstubs)


pretty sure this changes in a newer version of rubocop, but that change is I believe breaking so we can change that back when we update it.

majormoses · 2017-12-29T23:28:00Z

bin/check-es-indices-sizes.rb

-    # rubocop:disable LineLength
-    used_in_bytes = nodes_being_used.map { |node| node['fs']['data'].map { |data| data['total_in_bytes'] - data['available_in_bytes'] }.flatten }.flatten.inject { |sum, x| sum + x }
-    # rubocop:enable LineLength
+    # TODO: come back and cleanup all these rubocop disables with a little refactor


I know this is not the code that was changed but somehow rubocop started complaining. This is super ugly and hard to read, we should come back and refactor this later.

majormoses · 2018-01-26T23:44:34Z

@csoleimani any chance on coming back to get this cleaned up and over the line?

thomasriley

As requested by @majormoses I have just tested the --cert option against an Elasticsearch cluster that has HTTPS enabled and it works as expected.

[riley:...sensu-plugins-elasticsearch]$ bundle exec bin/check-es-cluster-status.rb --host elastic.example.com --port 9200 --https true --user 'admin' --password 'password' --cert ~/Downloads/Root.crt
ESClusterStatus OK: Cluster is green

majormoses · 2018-02-19T03:37:57Z

@thomasriley thanks for testing I will review this tonight or tomorrow and hopefully merge and release this.

majormoses · 2018-02-19T21:03:30Z

Looks like we need a rebase.

majormoses · 2018-02-19T21:09:28Z

I rebased for you, sorry for the long delay.

majormoses · 2018-02-19T21:11:57Z

To avoid confusion I am gonna rename the option from --cert to --cert-file to make it clear that this supports passing a file name not the actual cert directly via cli.

majormoses · 2018-02-19T21:22:07Z

Hmm one more thought is that -c is usually used to specify a critical threshold. I checked and none of the checks that this was added to need that but there are others such as this one that do in this repo. I think we should remove the short option to keep it consistent.

thomasriley · 2018-02-19T22:26:14Z

@majormoses I agree on both using the --cert-file name to ensure that option is descriptive and avoid using the short -c to avoid confusion and maintain consistency.

…itical thresholds in other checks in this repo as well as that being a standard across plugins.

majormoses · 2018-02-20T01:48:45Z

released: https://rubygems.org/gems/sensu-plugins-elasticsearch/versions/1.10.0

wtibbitts · 2019-12-04T18:05:37Z

Why was this not added to all checks?

majormoses · 2019-12-04T22:16:24Z

@jwsomis cant say but you are welcome to open up a PR for any missing ones.

csoleimani · 2019-12-05T02:07:59Z

I think I had some problems with the ones I didn't add it to, but it was so long ago that I don't remember what they are. Feel free to give it a shot, though!

wtibbitts · 2019-12-05T02:59:20Z

I started trying to, but am rather new to sensu plugins and ran into issues trying to figure out what the correct build steps are for bonsai assets. Could you enlighten me? Wes

…

On Wed, Dec 4, 2019, 6:08 PM Cameron Soleimani ***@***.***> wrote: I think I had some problems with the ones I didn't add it to, but it was so long ago that I don't remember what they are. Feel free to give it a shot, though! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#101?email_source=notifications&email_token=AA2P6TFOOD66IMFHTXQLC2LQXBPABA5CNFSM4EF2PHDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7GZMI#issuecomment-561933489>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2P6TDH6AYIQPOHDOVO3ELQXBPABANCNFSM4EF2PHDA> .

csoleimani · 2019-12-05T04:53:04Z

This is the best guide I have seen around sharing assets:

https://discourse.sensu.io/t/contributing-assets-for-existing-ruby-sensu-plugins/1165

wtibbitts · 2019-12-05T15:30:01Z

Thanks, Cameron! I was missing the TravisCI portion.

…

On Wed, Dec 4, 2019 at 8:53 PM Cameron Soleimani ***@***.***> wrote: This is the best guide I have seen around sharing assets: https://discourse.sensu.io/t/contributing-assets-for-existing-ruby-sensu-plugins/1165 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#101?email_source=notifications&email_token=AA2P6TD6ZV2E4AB7B5D4SH3QXCCLBA5CNFSM4EF2PHDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7PH7Y#issuecomment-561968127>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2P6TBDBCCCTTY6IHGCYPTQXCCLBANCNFSM4EF2PHDA> .

csoleimani mentioned this pull request Nov 29, 2017

Adding flag to disable "ask validation" #100

Open

majormoses added Status: Awaiting Response Status: Needs Review Type: Enhancement labels Dec 3, 2017

csoleimani closed this Dec 26, 2017

csoleimani reopened this Dec 26, 2017

majormoses requested review from eheydrick and sstarcher December 29, 2017 23:24

majormoses requested changes Dec 29, 2017

View reviewed changes

thomasriley reviewed Feb 18, 2018

View reviewed changes

majormoses removed the Status: Awaiting Response label Feb 19, 2018

majormoses added the Status: Needs Rebase label Feb 19, 2018

csolei2 and others added 3 commits February 19, 2018 13:07

adding cert option to some checks and metrics

242d2ac

ran rubocop -a

330234f

appease the cops

74a54ed

majormoses force-pushed the certs branch from db4ffef to 74a54ed Compare February 19, 2018 21:08

majormoses removed Status: Needs Rebase Status: Needs Review labels Feb 19, 2018

majormoses approved these changes Feb 19, 2018

View reviewed changes

rename cert to cert_file and improve descriptions

a1d4538

majormoses added the Status: Needs Review label Feb 19, 2018

thomasriley approved these changes Feb 19, 2018

View reviewed changes

remove short "-c" option to avoid confusion with it being used for cr…

d86b2b1

…itical thresholds in other checks in this repo as well as that being a standard across plugins.

majormoses merged commit 8243eab into sensu-plugins:master Feb 20, 2018

majormoses added Status: Needs Changelog and removed Status: Needs Review labels Feb 20, 2018

majormoses added a commit that referenced this pull request Feb 20, 2018

add changelog for #101

c12bdd2

majormoses removed the Status: Needs Changelog label Feb 20, 2018

vin01 mentioned this pull request May 18, 2018

Adding --cert-file option for all the checks which use RestClient #115

Merged

5 tasks

cwjohnston mentioned this pull request Dec 7, 2020

metrics-es-node-graphite.rb constructs invalid URL when cert file flag is used #174

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding cert option to some checks and metrics #101

adding cert option to some checks and metrics #101

csoleimani commented Nov 29, 2017 •

edited

Loading

majormoses commented Dec 3, 2017

csoleimani commented Dec 26, 2017

majormoses commented Dec 29, 2017 •

edited

Loading

majormoses commented Dec 29, 2017

majormoses left a comment

majormoses Dec 29, 2017

majormoses Dec 29, 2017

majormoses commented Jan 26, 2018

thomasriley left a comment •

edited

Loading

majormoses commented Feb 19, 2018

majormoses commented Feb 19, 2018

majormoses commented Feb 19, 2018

majormoses commented Feb 19, 2018

majormoses commented Feb 19, 2018 •

edited

Loading

thomasriley commented Feb 19, 2018

majormoses commented Feb 20, 2018

wtibbitts commented Dec 4, 2019

majormoses commented Dec 4, 2019

csoleimani commented Dec 5, 2019

wtibbitts commented Dec 5, 2019 via email

csoleimani commented Dec 5, 2019

wtibbitts commented Dec 5, 2019 via email

adding cert option to some checks and metrics #101

adding cert option to some checks and metrics #101

Conversation

csoleimani commented Nov 29, 2017 • edited Loading

Pull Request Checklist

General

New Plugins

Purpose

Known Compatibility Issues

majormoses commented Dec 3, 2017

csoleimani commented Dec 26, 2017

majormoses commented Dec 29, 2017 • edited Loading

majormoses commented Dec 29, 2017

majormoses left a comment

Choose a reason for hiding this comment

majormoses Dec 29, 2017

Choose a reason for hiding this comment

majormoses Dec 29, 2017

Choose a reason for hiding this comment

majormoses commented Jan 26, 2018

thomasriley left a comment • edited Loading

Choose a reason for hiding this comment

majormoses commented Feb 19, 2018

majormoses commented Feb 19, 2018

majormoses commented Feb 19, 2018

majormoses commented Feb 19, 2018

majormoses commented Feb 19, 2018 • edited Loading

thomasriley commented Feb 19, 2018

majormoses commented Feb 20, 2018

wtibbitts commented Dec 4, 2019

majormoses commented Dec 4, 2019

csoleimani commented Dec 5, 2019

wtibbitts commented Dec 5, 2019 via email

csoleimani commented Dec 5, 2019

wtibbitts commented Dec 5, 2019 via email

csoleimani commented Nov 29, 2017 •

edited

Loading

majormoses commented Dec 29, 2017 •

edited

Loading

thomasriley left a comment •

edited

Loading

majormoses commented Feb 19, 2018 •

edited

Loading